Use Absolute(true/false) vs NonNegative/Signed #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
SergeyKanzhelev
approved these changes
Oct 16, 2019
bogdandrutu
approved these changes
Oct 17, 2019
|
this is coordinated with #299. Needs to be in v0.2. Merging |
MrAlias
added a commit
to MrAlias/opentelemetry-specification
that referenced
this pull request
Nov 4, 2019
Update `Observer` definition to express their monotonic definition the same way as introduced in open-telemetry#312 .
Merged
SergeyKanzhelev
pushed a commit
that referenced
this pull request
Nov 22, 2019
Update `Observer` definition to express their monotonic definition the same way as introduced in #312 .
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
Update `Observer` definition to express their monotonic definition the same way as introduced in open-telemetry#312 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a response to late-arriving feedback on #250. @AloisReitbauer
This change from
SignedandNonNegativetoAbsolute = false/trueis coordinated with PR #299. I think this is a sensible improvement in naming.